Launch: use step-by-step launch flow after new onboarding with free plan

[razvanpapadopol]

*Editing Toolkit release notes: N/A (this PR is just cleaning up some unused code)

Changes proposed in this Pull Request

• Improve the fix added in https://github.com/Automattic/wp-calypso/pull/47421/files#diff-94cbcc079892f7f8fb113398707b6a9b6394766e051b1f2c28f98334ad25015fR375 to cover also the case when there is a plan value in store but that plan is free.
• Cleanup unused code and add comments.

Testing instructions - what should stay unchanged

1. Go to /new
2. Create a site with a paid plan and complete purchase
3. When clicking Launch button from the top bar in editor, you should be redirected to /start/launch-site which is the default Launch flow in Calypso.

Testing instructions - what should change

1. Go to /new
2. Create a site on a Free plan
3. Go to My Home and navigate to editor
4. Check if there is a plan object in store by executing wp.data.select( 'automattic/site' ).getSite( _currentSiteId )?.plan in post.php window in console.
5. When clicking Launch button from the top bar in editor, Step-by-step Launch modal should open over the editor.

Context

p1605290793102800-slack-CRNF6A9DX
#47421

[matticbot]

Test live: https://calypso.live/?branch=fix/launch-after-new-onboarding-with-free-plan

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~14 bytes added 📈 [gzipped])

name              parsed_size           gzip_size
gutenberg-editor        +27 B  (+0.0%)      +14 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D52861-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

[ciampo]

Putting the ( ! this.props.plan || this.props.plan.is_free ) check here may cause some confusion, since the isGutenboarding variable now carries a different meaning that is not just to do with the site creation flow.

Would it be better move the check under a separate siteHasFreePlan variable, and pass that variable to calypsoifyGutenberg?
The code on the Editing Toolkit side could then check for isGutenboarding && siteHasFreePlan, making the code more explicit on what's going on

[razvanpapadopol]

I agree there is a better way to do this and also prevent confusion. Opened #47504 to unblock current PR so we can quickly fix the issue from the Calypso side and then implement a more solid solution that involves deploying ETK and WBE.

[ciampo]

Agreed. Thank you for opening a separate issue to track this.

[ciampo]

Testing instructions - what should stay unchanged

1. Go to /new
2. Create a site with a paid plan and complete purchase
3. When clicking Launch button from the top bar in editor, you should be redirected to /start/launch-site which is the default Launch flow in Calypso.

When clicking on "Launch", I'm shown a prompt to confirm I want to leave the editor, and I'm then redirected to wordpress.com/home/[siteid]

Here's a screen recording, in case I'm missing any step

[ciampo]

When clicking on "Launch", I'm shown a prompt to confirm I want to leave the editor, and I'm then redirected to wordpress.com/home/[siteid]

Update: without sandboxing, I'm able to test the changes correctly.

Can be merged once the outstanding comments are discussed / addressed

[ciampo]

LGTM