Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing Toolkit: Update to 2.8.6 #47517

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Editing Toolkit: Update to 2.8.6 #47517

merged 1 commit into from
Nov 17, 2020

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Nov 17, 2020 •
edited
Loading

Changes proposed in this Pull Request

  • Version bump and changelog

Changes to Editing Toolkit since 2.8.5:

Testing instructions

  1. Load the diff (D52891-code) on your sandbox and confirm that the above changes work correctly
  2. Test that the new version of the plugin doesn't break Atomic sites by following the instructions in the "Atomic Testing" section at PCYsg-ly5-p2.

@ockham ockham added [Status] In Progress Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin labels Nov 17, 2020
@ockham ockham requested a review from a team November 17, 2020 16:58
@ockham ockham self-assigned this Nov 17, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/etk-2.8.6

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 17, 2020
@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D52891-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@ockham ockham marked this pull request as ready for review November 17, 2020 17:36
@ockham ockham merged commit 0d0b4e2 into master Nov 17, 2020
@ockham ockham deleted the update/etk-2.8.6 branch November 17, 2020 17:38
@matticbot matticbot removed [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ockham ockham

Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ockham @matticbot