-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sites Management Dashboard: add search mechanism #65505
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~33 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~3305 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~55 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great in my testing!
Nothing blocking, but a few thoughts:
- It would be nice if the search term were added to the URL:
/sites-dashboard?search=<term>
- It would be nice if the search term persisted between tabs.
- It would be nice if search updated the site count in the tabs.
f2a817c
to
6806bc1
Compare
That's fair. All three points will be worked on separated tasks since they're not really related to adding the search functionality. |
6806bc1
to
6f4b847
Compare
6f4b847
to
43e5c46
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7439092 Thank you @zaguiini for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
This PR adds the basic search mechanism used throughout Calypso on the SMD.
It's a starting point for searching sites and will be iterated upon by follow-up PRs, most likely #65501, and a future PR that allows customizing the search icon and removing the input fade (described in the comments).
Testing Instructions
Check out this branch, open SMD, and try inputting substring values for the URL, domain, name, or slug.
The "no result" state will be fixed in a follow-up issue.
Related to #65169.