Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me: ES6ify the Profile Links components #7773

Merged
merged 7 commits into from
Sep 2, 2016
Merged

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Aug 31, 2016

This PR ES6ifies the Profile Links components (profile-link, profile-links, profile-links-add-other and profile-links-add-wordpress):

  • Replacing require with import
  • Replacing module.exports with export default
  • Replacing var with let or const
  • Using method shorthand
  • Using this instead of this.constructor
  • Improving spacing and formatting here and there
  • Fixing too long lines

These components are used in /me, in the Profile Links card.

Note: there are target="_blank" occurrences which are to be fixed in a separate PR: #7680.

To test:

  • Get this branch going
  • Go to /me
  • Inspect the Profile Links card and verify there are no regressions in its functionality and appearance, including:
    • Verify adding a WordPress link works and stores it properly
    • Verify adding another URL works and stores it properly
    • Verify deleting a link works properly
    • Verify existing links are rendered properly
    • Verify the proper message is displayed when there are no profile links

/cc @roccotripaldi

Test live: https://calypso.live/?branch=update/es6ify-me-profile-link

@tyxla tyxla added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Type] Janitorial labels Aug 31, 2016
@tyxla tyxla self-assigned this Aug 31, 2016
@tyxla tyxla changed the title ES6ify the Profile Links components Me: ES6ify the Profile Links components Aug 31, 2016
@roccotripaldi
Copy link
Member

👍 Nice clean-up!

@roccotripaldi roccotripaldi added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 1, 2016
@tyxla tyxla force-pushed the update/es6ify-me-profile-link branch from 7a3c7da to f4b3630 Compare September 2, 2016 07:11
@tyxla tyxla merged commit 908d455 into master Sep 2, 2016
@tyxla tyxla deleted the update/es6ify-me-profile-link branch September 2, 2016 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants