Jetpack Plugins: Open links in plugin content in a new window #8744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
[Status] Needs Review
|
ok, this makes sense! we should have thought about it before... :) 🚢 |
johnHackworth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
tyxla
force-pushed
the
update/jetpack-plugins-content-links-new-window
branch
from
01d9991 to
99827f5
Compare
bisko
pushed a commit
that referenced
this pull request
Nov 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links in plugin content are always external, but we currently open them in the same window. This PR alters the normalization utility function
normalizePluginData()so it will open the links in the plugin content in a new window.To test:
http://calypso.localhost:3000/plugins/$plugin/$site, where$pluginis a plugin with links in the content, and$siteis one of your Jetpack sites (I used thegoogle-sitemap-generatorplugin for testing).target="_blank"fixes - as discussed and done in Add rel="noopener noreferrer" wherever target="_blank" is used #7680./cc @johnHackworth @ryelle @mtias