Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Woo branding update on some environments #97842

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented Dec 30, 2024

Proposed Changes

Enables Woo Branding update to staging, horizon, and wpcalypso environments

Why are these changes being made?

To prepare for internal testing: pdibGW-3QO-p2#comment-2951

Testing Instructions

  1. Reviewing the code changes should be sufficient.
  2. If you'd like to test the branding update, you can follow the instructions from any of these PRs:

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ilyasfoo ilyasfoo requested review from a team, chihsuan and rjchow December 30, 2024 06:48
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 30, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Enables Woo Branding update to staging, horizon, and wpcalypso environments

What do you think if we also enable the feature flag in wpcalypso.json for Calypso Live environment?

@ilyasfoo
Copy link
Contributor Author

ilyasfoo commented Dec 31, 2024

What do you think if we also enable the feature flag in wpcalypso.json for Calypso Live environment?

@chihsuan Sounds good! I've enabled it in e79113f

@ilyasfoo ilyasfoo merged commit 563f98b into trunk Dec 31, 2024
10 checks passed
@ilyasfoo ilyasfoo deleted the update/deploy-woo-branding-to-staging branch December 31, 2024 07:27
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants