Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for main brush, side brush, and vacuum motors #15

Closed
jacobperron opened this issue Mar 28, 2016 · 8 comments
Closed

Add support for main brush, side brush, and vacuum motors #15

jacobperron opened this issue Mar 28, 2016 · 8 comments

Comments

@jacobperron
Copy link
Member

Add subscribers to listen for the three different motor commands.

@jacobperron jacobperron added this to the 2.0.0 milestone Apr 19, 2016
@ghost
Copy link

ghost commented Feb 26, 2018

Is this still in the works?

@jacobperron
Copy link
Member Author

@zserlin1 I haven't had time to work on this. There was some work done on this a while ago (#36), perhaps I'll get to it one weekend. In the meantime, PRs always welcome :)

To make the API more clear for developers, I think using a custom message for controlling the motors would be good. A proposal for ca_msgs/MotorSetpoint:

    # For the main and side brush motors, provide a duty cycle in the range [-1, 1]
    # The range of acceptable values for the vacuum motor is [0, 1]
    float32 duty_cycle

eborghi10 referenced this issue in eborghi10/create_autonomy Mar 16, 2019
* Set BSD license for packages

* Restore BSD license from Autonomy Lab

* Fix instruction error

* Edit installation instructions and missing documentation
@nnarain
Copy link
Contributor

nnarain commented May 31, 2021

Hi. I was looking into adding a command topic for the vacuum motor. See nnarain@d221878

Currently implemented as a std_msgs/Float32. Would create_msgs/MotorSetPoint be preferable?

@vinnnyr
Copy link
Contributor

vinnnyr commented Jun 4, 2021

I would prefer a create_msgs/MotorSetPoint since std_msgs is in theory deprecated

@nnarain
Copy link
Contributor

nnarain commented Jun 4, 2021

Was not aware of that. Thanks!

@jacobperron
Copy link
Member Author

Yes, I am also in favor of a semantically meaning message (e.g. like create_msgs/MotorSetPoint).

@AdronTech
Copy link

Would it also be possible to merge this into the foxy branch?

@jacobperron
Copy link
Member Author

Here's a port for Foxy: #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants