Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag/Crash exploit #357

Open
SengyEU opened this issue May 24, 2024 · 1 comment
Open

Lag/Crash exploit #357

SengyEU opened this issue May 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@SengyEU
Copy link

SengyEU commented May 24, 2024

Describe the bug
Clicking on some gui buttons causes the server to lag.

To Reproduce
Steps to reproduce the behavior:

  1. Open EcoJobs gui (It works in another plugins too, e.g. EcoSkills as some reported on discord)
  2. Join 3/3 jobs (or whatever your limit is)
  3. Start spamming joining another job with autoclicker.

Expected behavior
It should cancel the action completely and don't do anything. Maybe add a cooldown to it?

Screenshots
Here is a video: https://media.discordapp.net/attachments/1019933037829574706/1241853823019122698/Minecraft__1.20.4_-_Multiplayer_3rd-party_Server_2024-05-19_22-42-12.mp4?ex=6650fbff&is=664faa7f&hm=438758f38260f24d5cbaa9d791f78c4db041bff615ce7839e389a4fe679da2b6&

Server Information (please complete the following information):

  • Version: Pufferfish version git-Pufferfish-49 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 852ea89 on HEAD)
  • Version of plugin and eco: eco version 6.70.1, EcoJobs version 3.57.0

Additional context
It only applies to items, which don't take you to another gui and have action on them (e.g. trying to join a job, when you have 3/3)

@SengyEU SengyEU added the bug Something isn't working label May 24, 2024
@WillFP
Copy link
Member

WillFP commented Jul 14, 2024

Not directly an eco bug, please open an issue on the discord however I'll leave this open in case a general patch can be made.

(note to self, if gui caching is more plugin-specific then it might be better to add a new builder method in ecomponent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants