Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration loader does not respect "provided" plugins #380

Open
NonSwag opened this issue Nov 4, 2024 · 0 comments
Open

Integration loader does not respect "provided" plugins #380

NonSwag opened this issue Nov 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@NonSwag
Copy link

NonSwag commented Nov 4, 2024

Describe the bug
Plugins that are not officially supported but provide a supported plugin (for example, Vault) are not detected as available hook

To Reproduce

  1. Install a plugin like ServiceIO (provides Vault)
  2. Start the server and wait for the log [eco] Loaded integrations: ...
  3. Look for Vault (not there)

Expected behavior

Because the plugin is not, but does provide vault, it should be used as dependency

Server Information:

  • Version: Paper 1.21.1
  • Version of eco: 6.74.3

Additional context

private static final Set<String> LOADED_PLUGINS = Arrays.stream(Bukkit.getPluginManager().getPlugins())

Adding all entries from PluginDescriptionFile#getProvidedPlugins (or for paper PluginMeta#getProvidedPlugins) would solve this issue

@NonSwag NonSwag added the bug Something isn't working label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant