Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ensureDelegationExist and ensureDelegationNotExist to the tests of staking compound #109

Open
chrisli30 opened this issue Nov 29, 2023 · 3 comments
Open

Add ensureDelegationExist and ensureDelegationNotExist to the tests of staking compound #109

chrisli30 opened this issue Nov 29, 2023 · 3 comments
Assignees
@imstar15
Labels
enhancement New feature or request Stale

Comments

@chrisli30
Copy link
Member

In the tests of #103, a pre-requisite function is missing from the tests,

  • In compound tests, delegations need to exist before running
  • In delegation tests, there should be no delegation set up before running

We need to create common functions, ensureDelegationExist and ensureDelegationNotExist for the above purposes.
@chrisli30 chrisli30 added the enhancement New feature or request label Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 18, 2024
@chrisli30 chrisli30 removed the Stale label Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 18, 2024
@chrisli30 chrisli30 removed the Stale label Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imstar15 imstar15

Labels
enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisli30 @imstar15