Skip to content
This repository has been archived by the owner on Jan 2, 2024. It is now read-only.

feature/ added entity type to submission #833

Closed

Conversation

toan-quach
Copy link
Member

No description provided.

Copy link

☂️ Python Cov

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8726 8267 95% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/taipy/core/_orchestrator/_orchestrator.py 98% 🟢
src/taipy/core/submission/_submission_converter.py 100% 🟢
src/taipy/core/submission/_submission_manager.py 100% 🟢
src/taipy/core/submission/_submission_model.py 100% 🟢
src/taipy/core/submission/submission.py 95% 🟢
TOTAL 99% 🟢

updated for commit: b6f3598 by action🐍

jrobinAV
jrobinAV previously approved these changes Nov 29, 2023
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
We can merge it if we want, but the most important is to do it again in taipy repository once core repo is merged into taipy repo.

@toan-quach Please let us know when the PR is opened on taipy.

Thx!

gmarabout
gmarabout previously approved these changes Nov 29, 2023
Copy link
Contributor

@gmarabout gmarabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments (they are more questions actually), but looks great to me!

tests/core/job/test_job_manager.py Outdated Show resolved Hide resolved
src/taipy/core/submission/submission.py Show resolved Hide resolved
@toan-quach toan-quach dismissed stale reviews from gmarabout and jrobinAV via e8636d0 November 29, 2023 13:51
@jrobinAV
Copy link
Member

jrobinAV commented Dec 4, 2023

The code is already merged in taipy repo, right?
Can we close this PR?

@toan-quach
Copy link
Member Author

Yep can! Let me close it!

@toan-quach toan-quach closed this Dec 4, 2023
@toan-quach toan-quach deleted the feature/add-entity-type-to-submission-entity branch December 4, 2023 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants