Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the exposed_type parameter of DataNode to accept actual Python types #398

Open
trgiangdo opened this issue Dec 5, 2022 · 20 comments · May be fixed by #2296
Open

Expand the exposed_type parameter of DataNode to accept actual Python types #398

trgiangdo opened this issue Dec 5, 2022 · 20 comments · May be fixed by #2296
Assignees
Labels
Core: Data node Core Related to Taipy Core 📄 Documentation Internal or public documentation good first issue New-contributor friendly 📈 Improvement Improvement of a feature. 🟩 Priority: Low Low priority and doesn't need to be rushed

Comments

@trgiangdo
Copy link
Member

trgiangdo commented Dec 5, 2022

Description

For now, the exposed_type parameter only accepts a string (`"pandas", "numpy") or a custom python class.

This ticket proposes to expand the parameter type to accept actual Python types for the predefined types:

  • numpy.array
  • pandas.DataFrame
@trgiangdo trgiangdo added 🟩 Priority: Low Low priority and doesn't need to be rushed 📈 Improvement Improvement of a feature. labels Dec 5, 2022
@jrobinAV jrobinAV transferred this issue from Avaiga/taipy-core Nov 13, 2023
@jrobinAV jrobinAV added Core Related to Taipy Core 📄 Documentation Internal or public documentation Core: Data node good first issue New-contributor friendly labels Nov 17, 2023
joaoandre-avaiga pushed a commit that referenced this issue Nov 23, 2023
dinhlongviolin1 pushed a commit that referenced this issue Dec 4, 2023
@sqrt676
Copy link

sqrt676 commented Mar 1, 2024

Can i help out here ?

@trgiangdo
Copy link
Member Author

Thank you @sqrt676. I assigned the ticket to you.

Let us know if you need more information on this.

@sqrt676
Copy link

sqrt676 commented Mar 2, 2024

Thanks @trgiangdo , will ask for information wherever needed.

@trgiangdo
Copy link
Member Author

Hello @sqrt676, any update on this issue?

@ranjanmangla1
Copy link

@trgiangdo can I take this one?

@trgiangdo
Copy link
Member Author

Absolutely. I will assign the issue to you @ranjanmangla1.

If you have any question on the topic, feel free to ask here.

@ranjanmangla1
Copy link

@trgiangdo just want to ask, since this issue is almost 18 months old now, what changes have been to taipy? and since modin has been deprecated in taipy, is there a need to provide support for modin.pandas.DataFrame?

@trgiangdo
Copy link
Member Author

Oh, you're right. Let me update the description. Other than that, there hasn't been any other change that affect this issue.

Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Jul 26, 2024
@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This issue has been unassigned automatically because it has been marked as "🥶Waiting for contributor" for more than 14 days with no activity.

@NILAY1556
Copy link

hi , @trgiangdo
I'd like to contribute to this issue. Is it still open?

@jrobinAV
Copy link
Member

Hello @NILAY1556,

Yes, it is still open.

Let me assign it to you.

Thank you,

@jrobinAV jrobinAV added hacktoberfest hacktoberfest issues hacktoberfest - 100💎 Issues rewarded by 100 points labels Sep 25, 2024
toan-quach added a commit that referenced this issue Sep 27, 2024
feature/enterprise/#398 load enterprise _TaskFunctionWrapper
toan-quach added a commit that referenced this issue Oct 3, 2024
Bug/Fix failing issue on enterprise due to import manager
Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Oct 10, 2024
toan-quach added a commit that referenced this issue Oct 18, 2024
feature/enterprise/#398 external services integration preparation
Copy link
Contributor

This issue has been unassigned automatically because it has been marked as "🥶Waiting for contributor" for more than 14 days with no activity.

@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Oct 25, 2024
@SaiNivedh26
Copy link

Hey can I take up this issue ?

@jrobinAV
Copy link
Member

@SaiNivedh26 That would be great. Thank you.

Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 17, 2024
@sohamkumar05
Copy link

sohamkumar05 commented Nov 21, 2024

@jrobinAV, please confirm whether this issue needs to be open. I already see a merged PR done based on the requirements mentioned in the issue. If yes, please elaborate on the requirement, because what is asked in the issue is already addressed.

Also, I would like to take this issue if requirements are yet to be fulfilled.

@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 21, 2024
@jrobinAV
Copy link
Member

jrobinAV commented Nov 25, 2024

Hello @sohamkumar05,

Thank you for your help. Yes, indeed, this is still open to contribution. Let me assign it to you.

Let me give a fake example with a CSV data node. Today, the code should look like the following.

import taipy as tp

cfg = tp.config.Config.configure_csv_data_node(
    id="my_id", scope: tp.Scope.GLOBAL, default_path="my/path.csv",
    exposed_type="pandas") # The `exposed_type` parameter is a string

dn = tp.create_global_datanode(cfg)

This issue is about accepting the following code:

import taipy as tp
import pandas as pd

cfg = tp.config.Config.configure_csv_data_node(
    id="my_id", scope: tp.Scope.GLOBAL, default_path="my/path.csv",
    exposed_type=pd.DataFrame)  # The `exposed_type` can be a predefined DataFrame type

dn = tp.create_global_datanode(cfg)

@jrobinAV jrobinAV assigned sohamkumar05 and unassigned SaiNivedh26 Nov 25, 2024
@sohamkumar05 sohamkumar05 linked a pull request Dec 2, 2024 that will close this issue
11 tasks
sohamkumar05 added a commit to sohamkumar05/taipy that referenced this issue Dec 2, 2024
sohamkumar05 pushed a commit to sohamkumar05/taipy that referenced this issue Dec 2, 2024
trgiangdo added a commit to sohamkumar05/taipy that referenced this issue Dec 5, 2024
Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Dec 10, 2024
jrobinAV added a commit to sohamkumar05/taipy that referenced this issue Dec 10, 2024
sohamkumar05 added a commit to sohamkumar05/taipy that referenced this issue Dec 11, 2024
@jrobinAV jrobinAV removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Dec 12, 2024
jrobinAV added a commit to sohamkumar05/taipy that referenced this issue Dec 13, 2024
jrobinAV added a commit to sohamkumar05/taipy that referenced this issue Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core: Data node Core Related to Taipy Core 📄 Documentation Internal or public documentation good first issue New-contributor friendly 📈 Improvement Improvement of a feature. 🟩 Priority: Low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants