Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the value of a property through dev tools doesn't work the first time #14719

Closed
MrJul opened this issue Feb 23, 2024 · 0 comments · Fixed by #14722
Closed

Changing the value of a property through dev tools doesn't work the first time #14719

MrJul opened this issue Feb 23, 2024 · 0 comments · Fixed by #14722

Comments

@MrJul
Copy link
Member

MrJul commented Feb 23, 2024

Describe the bug

Changing the value of a property through the ComboBox presented in the dev tools doesn't work the first time.

To Reproduce

  1. Run any app with dev tools attached (I've used the ControlCatalog)
  2. Open the dev tools with F12 and select any control in the tree view
  3. Change any property value through the appropriate ComboBox, TextBox or CheckBox
  4. Observe the newly set value incorrectly not updating the control
  5. Change it again: it should now work

Expected behavior

Changing a property in the dev tools should always work.

Environment

Reproduced on latest master e35e949
Does not happen on 11.0.9

Additional context

PropertyValueEditorView.ValueConverter ignores the first update which was supposed to contain the initial value:
https://github.com/AvaloniaUI/Avalonia/blob/e35e94902eb4eef415e205fa0ca7e911ac2aa2f4/src/Avalonia.Diagnostics/Diagnostics/Views/PropertyValueEditorView.cs#L318C1-L324C1

The initial value isn't received anymore, so this code could probably be deleted.
The change in behavior probably comes from #13970 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant