-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using ExtendClientAreaToDecorationsHint disables window shadow on Windows #9989
Comments
I did some digging and found that this is a regression caused by #8393 If I revert the changes from the PR, then the drop shadow comes back i.e. change |
@Tetedeiench @maxkatz6 If you want to solve the flickering/white area appearing while resizing and white window flashing during window show I could give some tips on how to solve those issues, as i also had to solve them in the custom window chrome code in ControlzEx. |
@batzen I think we are all interested in a better fix - my PR fixed the window background turning white when resizing, but it has implications way beyond the fix and probably should be questioned af of now. Now, I'm a huge newbie when it comes to such topics, and I just happened to stumble upon something that might have done the trick, but ultimately wasn't satisfying. I'm not sure I'm qualified to fix this with my current capabilities in Win32 topics ! |
@batzen @Tetedeiench @navhaxs indeed windowing backend on win32 needs some cleanup. Especially when it first was written before WinUI compositor was used, and had to be patched in multiple places (including #8393) to get it work better with composition. |
Hi, what is the status on this issue? The corresponding issues were all closed as not planned. Does this mean that this issue will be fixed after the release of version 11 in e.g. version 11.1 or 11.2, etc? |
I would suggest that #8393 be reverted in the meantime until a better solution can be found. Because unfortunately the PR does break the expected behaviour here :( :( I don't think it would be good for window shadows to be broken with Isn't win32 ticky... |
Well, either you suffer from a big white flash when resizing your app, or you are missing your shadows - it's really a "pick your poison" issue currently. I spent a ton of time trying to find a solution that could enable both, without success :( |
@Tetedeiench You can solve both issues. I solved them in ControlzEx. |
Hi just a friendly bump on this, maybe @batzen? :) I just saw the 11.0 RC dropped (❤️!), so would be good to see if this can be fixed soon-ish As a workaround I personally am doing this to fix my window drop shadows, as I am rolling my own window chrome in my app:
|
Sorry for the delay. The only thing I noticed is that the content lags a bit behind a resize, but the background of the not yet rendered area is transparent. |
Thanks @batzen! If that's the case, can I kindly suggest we revert #8393 ? Seeing comments like #8393 (comment) |
I know it's been a while, but any update on this issue? Still seems broken in V11.0.3. |
Seems to me that this been fixed on latest Avalonia 🎉. I tested 11.0.9 release. |
Closing it acc to feedback. If issue comes back, open a new bug report. |
Apologies, this is actually still broken on Windows 10. On Windows 11 we get the drop shadows, but not on Windows 10. Suppose most people are on Windows 11 nowadays and so don't run into this bug. |
I got same issue. |
@rabbitism @navhaxs could you check again using latest nightly builds? |
Just tested on 3e51397 (current master), confirming still broken on Windows 10 As you can see when you zoom in, there are no drop shadows. Regression quoted below -
|
/cc @emmauss |
Describe the bug
When using "ExtendClientAreaToDecorationsHint=True" on Avalonia 11.0.0-preview1 or later, app window doesn't have a shadow and looks very "flat".
To Reproduce
Expected behavior
Window having a shadow even when using "ExtendClientAreaToDecorationsHint"
Screenshots
Desktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: