Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property.findSeparator is scanning strings character-by-character #19

Closed
InPermutation opened this issue Oct 4, 2023 · 1 comment
Closed

Comments

@InPermutation
Copy link
Contributor

Related to #16 #17 #18 - findSeparator is also showing up in my profiler as a significant CPU user; I think it can be significantly sped up by using e.g.

for (const match of this.linesContent[0].matchAll(/[\t\f :=]/g)) {
  if (!match.index) { continue; }

  const position = match?.index

but I haven't finished drafting the PR, so I'm filing this Issue instead 😎

@nbouvrette
Copy link
Contributor

@InPermutation the fix is now available in 3.3.2

Let me know if you see anything I might have missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants