Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added descriptions for frontend projects in data.json #1049

Closed
wants to merge 2 commits into from

Conversation

Mayank-704
Copy link

@Mayank-704 Mayank-704 commented Dec 22, 2024

Closes: #1046

  • Title: Added descriptions for frontend projects in data.json
  • Name: Mayank Gupta
  • Idenitfy yourself: KWOC Contributor

Describe the add-ons or changes you've made 📃

I added detailed descriptions for the frontend projects in the data.json file as part of the open-source contribution. These descriptions provide better clarity for the frontend project entries.
A sample:

  • "description": "The hotstar-clone project is a web page that replicates the interface of the popular streaming platform Hotstar using HTML5, CSS3, and JavaScript. This project focuses on creating a responsive design with interactive features such as navigation, content highlights, and media sections. It’s a valuable project for practicing the integration of JavaScript with HTML and CSS to enhance interactivity and user engagement."

Screenshots 📷

screenshot webp

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

Descriptions have been added in the src/database/data.json file for frontend projects. Please review and let me know if any adjustments are needed.

Copy link

vercel bot commented Dec 22, 2024

@Mayank-704 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Resolve merge conflicts
  • Link your issue properly
  • Don't change indentation, only commit your work

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Dec 23, 2024
@Mayank-704
Copy link
Author

@Avdhesh-Varshney Do I need to close this PR and make a new one with single commit or I can do one more commit here for resolving merge conflict.

@Avdhesh-Varshney
Copy link
Owner

@Avdhesh-Varshney Do I need to close this PR and make a new one with single commit or I can do one more commit here for resolving merge conflict.

Yes, work in this pr

@Mayank-704
Copy link
Author

Mayank-704 commented Dec 23, 2024

@Avdhesh-Varshney Done

  • Resolved Merge Conflict (Didn't do text formatting)
  • Linked Issue Properly

@@ -78,7 +78,7 @@
"date": "Sat Nov 02 2024",
"github_url": "https://github.com/Suvadip-sana",
"avatar_url": "https://avatars.githubusercontent.com/u/78638404?v=4",
"description": "No description found",
"description": "This project is a frontend replica of the popular e-commerce platform Amazon. It demonstrates key web development skills by implementing a visually appealing and responsive user interface. Built using HTML5 and CSS3, the clone showcases features like a dynamic product display, categories, and search functionality, offering a hands-on experience with creating a scalable and intuitive e-commerce website. This project is ideal for learners looking to deepen their understanding of UI/UX design, layout structuring, and styling techniques in web development. It’s also a great portfolio piece for showcasing expertise in frontend development.",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the indentation of description

@Mayank-704 Mayank-704 removed their assignment Dec 24, 2024
@Mayank-704 Mayank-704 closed this by deleting the head repository Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: Update the description of the projects in data.json file
2 participants