Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstraction Layer: Dot Definitions #41

Open
uber5001 opened this issue Mar 19, 2014 · 1 comment
Open

Abstraction Layer: Dot Definitions #41

uber5001 opened this issue Mar 19, 2014 · 1 comment

Comments

@uber5001
Copy link
Collaborator

I think this needs to be cleaned up a lot in our code.

The idea is that a Dot represents an AudioNode, but a Dot is not an AudioNode. Our code should work with dot definitions, and those definitions should work with AudioNodes. Our application should not work with AudioNodes directly. This allows for the easy addition of custom nodes that are not defined in the Web Audio API spec itself, such as MIDI nodes and user-made nodes.

This layer is already partially defined ( and works! see pull #40 ), but not completed.

The only issue I have with this abstraction layer is that there will probably be functions in the definitions in nodes.js. My first instinct points out that if there are functions, then the definitions can't be JSON.stringify'd. But is that needed?

@Awk34
Copy link
Owner

Awk34 commented Mar 19, 2014

why would we want to stringify definitions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants