Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shared): remove unneeded defensive code #3

Merged
merged 3 commits into from
Jun 25, 2020
Merged

fix(shared): remove unneeded defensive code #3

merged 3 commits into from
Jun 25, 2020

Conversation

hamzahamidi
Copy link
Contributor

Remove condition that always evaluates to false. value can't be null & undefined at the same time

@hamzahamidi
fix(shared): remove unneeded defensive code
041d006 
Remove condition that always evaluates to false. `value` can't be null & undefined at the same time
@Debaerdm Debaerdm added the bug Something isn't working label May 25, 2020
Debaerdm
Debaerdm reviewed May 25, 2020
View reviewed changes
Copy link
Contributor

@Debaerdm Debaerdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add test CI

@hamzahamidi
Copy link
Contributor Author

hamzahamidi commented May 25, 2020 •
edited
Loading

You need to add CI before merging this pr

@itupix itupix merged commit e10faca into AxaFrance:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Debaerdm Debaerdm Debaerdm left review comments

@itupix itupix itupix approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamzahamidi @Debaerdm @itupix