feat: add possibility to mount config map on ephemeral job agent #1505
Conversation
| Optional<String> configMapMountPathOpt = Optional.ofNullable(executorContext.getEnvironmentVariables().get("CONFIG_MAP_MOUNT_PATH")); | ||
| if (configMapNameOpt.isPresent()) { | ||
| String configMapName = configMapNameOpt.get(); | ||
| String mountPath = configMapMountPathOpt.orElse("/home/"); // Default mount path if not specified |
There was a problem hiding this comment.
I would move the default mount path to /tmp or /mnt. From my POV /home is not safe to be used as a mount point.
There was a problem hiding this comment.
I set it as default because it is used by AWS for instance to fetch its .aws/config folder but you're right as a safe point i'll move to tmp !
|
Thank you @BenjaminDecreusefond |
|
Hi @alfespa17 ! Do you have an ETA for when this will be available in executor image ? :) |
|
Maybe I create the image later today I would like to see if I have some free time to add support for variable sets |
|
Ok sure thanks ! |
|
Hey @alfespa17 ! Sorry to bother you, but do you have any updates about this ? :) |
You can try https://github.com/AzBuilder/terrakube/releases/tag/2.24.0-beta.5 |
|
Btw thank you @stanleyz I've been using the new images of the API and can confirm that jobs starts much faster now ! |
Hey @alfespa17 !
We are currently working on ephemeral agents and we would like to add the ability to mount volumes on the jobs to allow for custom configuration like passing configuration files to interact with cloud providers. Do you think that could be a cool feature ?
Also, following this PR I update the message in the Terrakube UI to tell user that they can use regex for branch matching as well !
Regards !