Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for PathBuf/OsString #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add support for PathBuf/OsString #1

wants to merge 1 commit into from

Conversation

AzHicham
Copy link
Owner

No description provided.

@AzHicham AzHicham force-pushed the haz/add-support-for-pathbuf branch 15 times, most recently from a1aa034 to bd0c30c Compare May 20, 2023 08:02
@AzHicham AzHicham force-pushed the haz/add-support-for-pathbuf branch from bd0c30c to 7e80757 Compare May 20, 2023 09:49
@Stygmates
Copy link

Hi,
What's the status on this? What is needed for this PR to be ready?

@AzHicham
Copy link
Owner Author

AzHicham commented Nov 17, 2023 •
edited
Loading

Hi, What's the status on this? What is needed for this PR to be ready?

Hello,

Sorry I didn't find time to work on it.
Status:

  • It does work on Linux/Unix but not on Windows ... because of the implementation of OsPathBuf which is platform specific.
  • Need tests

I have found a workaround which works very well with diesel https://docs.rs/camino/latest/camino/struct.Utf8PathBuf.html

Example:

    #[diesel(serialize_as = String, deserialize_as = String)]
    pub filename: Utf8PathBuf,

@Stygmates
Copy link

Wow thanks for the workaround I think it's perfect for my usage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AzHicham @Stygmates