Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify schnorr and ecdsa account contracts to store the public key #1007

Closed
PhilWindle opened this issue Jul 10, 2023 · 1 comment · Fixed by #1080
Closed

Modify schnorr and ecdsa account contracts to store the public key #1007

PhilWindle opened this issue Jul 10, 2023 · 1 comment · Fixed by #1080
Assignees

Comments

@PhilWindle
Copy link
Collaborator

Now that we have account contracts working with Schnorr and ECDSA signatures, it would be great to update these so we don't have to pass in the public key for signature verification. Instead, we should provide an initial public key at contract creation. This will need to be nullified and re-created with each read.

Once this is achieved, the next step will be to add a method by which the public key can be rotated.

@spalladino
Copy link
Collaborator

spalladino commented Jul 11, 2023

Key rotation is blocked until we have transient commitments. For now, we can implement this as a private constant note, so we don't need to nullify it on every read. Consider using ImmutableSingleton in Noir to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants