Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add NFT tutorial #10161

Merged
merged 26 commits into from
Dec 23, 2024
Merged

feat(docs): add NFT tutorial #10161

merged 26 commits into from
Dec 23, 2024

Conversation

critesjosh
Copy link
Contributor

Adds an NFT tutorial to the docs.

Removes the token contract tutorial.

closes: #10113

@critesjosh critesjosh marked this pull request as ready for review December 10, 2024 21:18
@AztecBot
Copy link
Collaborator

AztecBot commented Dec 10, 2024

Docs Preview

Hey there! 👋 You can check your preview at https://67699e5662c055667ec6d063--aztec-docs-dev.netlify.app

@critesjosh critesjosh requested a review from a team December 11, 2024 19:04
@signorecello
Copy link
Contributor

lgtm after conflicts solved @critesjosh

Copy link
Contributor

@rahul-kothari rahul-kothari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will review the remaining stuff in a bit!

Copy link
Contributor

@rahul-kothari rahul-kothari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer comments

critesjosh and others added 4 commits December 16, 2024 16:14
Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Copy link
Contributor

@rahul-kothari rahul-kothari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a commit for couple of changes:

  • the nft tutorial hyperlinked code to token code. Fixed
  • added some missing docs:start stuff
  • added some explanation on transient storage and other functions

Copy link
Contributor

Changes to public function bytecode sizes

Generated at commit: f1f1d06386103b7488f9a7ad526a2af23ff9e318, compared to commit: d340f0b0c2c97b59d2a8830bdae452d85945322c

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
AvmTest::public_dispatch -1,349 ✅ -2.06%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
AvmTest::public_dispatch 64,063 (-1,349) -2.06%

@critesjosh critesjosh merged commit 2412602 into master Dec 23, 2024
49 checks passed
@critesjosh critesjosh deleted the jc/nft-tutorial branch December 23, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Replace token contract tutorial with NFT contract tutorial
5 participants