Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attestation Pool: Reject attestations that are not for the current slot #10322

Closed
Maddiaa0 opened this issue Nov 30, 2024 · 0 comments · Fixed by #10450
Closed

Attestation Pool: Reject attestations that are not for the current slot #10322

Maddiaa0 opened this issue Nov 30, 2024 · 0 comments · Fixed by #10450
Assignees
Labels
A-devops Area: Devops. E.g. CI / build systems P-high 🔥 Priority: high. Do this task next.

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Nov 30, 2024

Overview

Related to caching the epoch information inside the attestation pool the node is accepting attestations for any slot, we need to filter attestations for the node's current view of the slot.

Validating logic must be added to the gossipsub layer to prevent it forwarding attestations and block proposals that it deems are invalid

Logs from a recent release around the time it crashed
Image

#10327 solves some of the problem, but we also want the p2p layer to have this check integrated into gossip sub, to prevent forwarding of messages which are not for the correct height.

@Maddiaa0 Maddiaa0 added A-devops Area: Devops. E.g. CI / build systems P-high 🔥 Priority: high. Do this task next. labels Nov 30, 2024
@Maddiaa0 Maddiaa0 self-assigned this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Devops. E.g. CI / build systems P-high 🔥 Priority: high. Do this task next.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant