feat: add priority fees to gas settings #10763
Conversation
LeilaWang
requested review from
jeanmon,
IlyasRidhuan and
fcarreiro
as code owners
LeilaWang
force-pushed
the
lw/priority_fees
branch
from
6922098 to
7b84c30
Compare
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
| @@ -20,13 +21,20 @@ export async function cancelTx( | |||
| return; | |||
| } | |||
|
|
|||
| const maxFeesPerGas = new GasFees( | |||
There was a problem hiding this comment.
Do we need to also increase the max fee per gas? I'd expect only increasing priority fees for cancellation 🤔
There was a problem hiding this comment.
I included max fees because the gasSettings passed to this function is fetched from the previous tx. So the max fees might be tailored to only fit the previous tx's fees. But now you pointed this out, I guess a better approach is for the user to also be able to increase the max fees for this new tx. Will change it now! Thanks 😃
| @@ -46,6 +47,7 @@ inline void read(uint8_t const*& it, GasSettings& gas_settings) | |||
| read(it, gas_settings.gas_limits); | |||
| read(it, gas_settings.teardown_gas_limits); | |||
| read(it, gas_settings.max_fees_per_gas); | |||
| read(it, gas_settings.max_priority_fees_per_gas); | |||
There was a problem hiding this comment.
I think we also need to update fee calculation in AvmTraceBuilder::pay_fee
There was a problem hiding this comment.
Oh right! Didn't realise fee computation is already implemented there.
Please read contributing guidelines and remove this line.