chore: clean up translator circuit builder function definitions #10944
+80
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it-builder-cleanup
maramihali
changed the title
maramihali
changed the title
Rumata888
reviewed
Dec 24, 2024
| @@ -58,12 +58,14 @@ TEST(TranslatorCircuitBuilder, CircuitBuilderBaseCase) | |||
|
|
|||
| Fq previous_accumulator = Fq::random_element(); | |||
|
|
|||
| // Create a circuit builder | |||
| auto circuit_builder = TranslatorCircuitBuilder(v, x); | |||
There was a problem hiding this comment.
What's the point in moving this?
There was a problem hiding this comment.
none anymore as I made the functions below static
Rumata888
reviewed
Dec 24, 2024
| * | ||
| * @details Translator Circuit Builder builds a circuit the purpose of which is to calculate the batched | ||
| * @details Translator Circuit Builder builds a circuit whose purpose is to calculate the batched |
Rumata888
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the core functions in
TranslatorCircuitBuilderwere not actually defined as part of the class. This PR addresses it, which removes the need to resolve the scope of member variables in the class, when used in those functions, and constified / staticfied function signatures where appropriate