chore(ci): Clean up stale image tags #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
approved these changes
Sep 1, 2023
|
LGTM |
spalladino
force-pushed
the
palla/clean-image-tags
branch
from
400aa0f to
661d7a0
Compare
ludamad
force-pushed
the
palla/clean-image-tags
branch
from
f5373a6 to
661d7a0
Compare
ludamad
pushed a commit
that referenced
this pull request
Sep 5, 2023
🤖 I have created a new Aztec Packages release --- ## [0.1.0-alpha58](v0.1.0-alpha57...v0.1.0-alpha58) (2023-09-05) ### Miscellaneous * **ci:** Clean up stale image tags ([#1818](#1818)) ([3c8b7b8](3c8b7b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at cleaning up image tags when a tag operation fails due to limit exceeded. The
clean_image_tagsloops over all image tags that look like a commit, and check if the commit is anywhere in git. If it isn't, it's because it belongs to a branch that got deleted (most likely, a PR that was merged) and we can safely kill it.We can still theoretically hit the 1000 limit in this scenario, but I think it's a lot less likely. A local test run of the script showed that most image tags correspond to non-existing commits.