Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] aztec-node doesn't sync fast enough on 2 core runners #5555

Closed
ludamad opened this issue Apr 3, 2024 · 3 comments
Closed

[e2e] aztec-node doesn't sync fast enough on 2 core runners #5555

ludamad opened this issue Apr 3, 2024 · 3 comments
Assignees

Comments

@ludamad
Copy link
Collaborator

ludamad commented Apr 3, 2024

image

This seems to come up on the lower core runners. While annoying to uncover it, its a chance to make things more robust :)

Example https://github.com/AztecProtocol/aztec-packages/actions/runs/8540912819/job/23399819123

@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 3, 2024
@benesjan benesjan self-assigned this Apr 4, 2024
@benesjan
Copy link
Contributor

benesjan commented Apr 4, 2024

I spent some time on this today and the error gets thrown by a callPrivateFunction oracle callback and it gets thrown because it does not find the contract instance in PXE database. The oracle is most likely called from account contract entrypoint (in AppPayload). The name of the problematic contract was not logged so I created this PR which logs all the contract deployments.

The only way for the contract to get to the PXE db is via PXE.registerContract(...) call. Once I have the problematic contract name I'll be able to determine where exactly the contract fails to get added (by comparing it to the logs of passing test).

This not a node sync issue but probably some kind of race condition.

@benesjan
Copy link
Contributor

@ludamad have you stumbled upon this again? If not I would close this.

@ludamad
Copy link
Collaborator Author

ludamad commented Apr 23, 2024

I've lost track of what's gone in though I was seeing it a bit ago. We can close it

@ludamad ludamad closed this as completed Apr 23, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants