Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Keys_Incoming): Appsiloed incoming key is useless #6955

Closed
Tracked by #5606
LHerskind opened this issue Jun 6, 2024 · 2 comments
Closed
Tracked by #5606

refactor(Keys_Incoming): Appsiloed incoming key is useless #6955

LHerskind opened this issue Jun 6, 2024 · 2 comments
Assignees

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Jun 6, 2024

The app-siloed incoming viewing key is currently completely useless and a waste of constraints.

The non-hardened keys allow anyone with knowledge of an app siloed incoming viewing secret key to derive the incoming master key. Making it completely useless.

In #6432 I chose to bypass the computation and extra constraints. The code is still there but the functions are just exiting early returning the input keys. Kept like that so it did not require any plumbing changes.

@iAmMichaelConnor
Copy link
Contributor

It it known

image

(from the original diagram)

@sklppy88 sklppy88 self-assigned this Jul 11, 2024
@sklppy88 sklppy88 moved this from Todo to Done in A3 Aug 6, 2024
@nventuro
Copy link
Contributor

nventuro commented Nov 7, 2024

Closing as this is now deleted.

@nventuro nventuro closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants