Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding tags to encrypted logs #9566

Merged
merged 1 commit into from
Nov 2, 2024
Merged

feat: adding tags to encrypted logs #9566

merged 1 commit into from
Nov 2, 2024

Conversation

sklppy88
Copy link
Contributor

@sklppy88 sklppy88 commented Oct 30, 2024 •
edited
Loading

This PR adds tags to encoded and encrypted notes. the encrypted log now populates the tag field.

Also this adds a function to IndexedTaggingSecret in both ts and nr that computes the tag from the required information.

@sklppy88 sklppy88 mentioned this pull request Oct 30, 2024
Merged
@sklppy88 Graphite App
Copy link
Contributor Author

sklppy88 commented Oct 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite Graphite

@sklppy88 sklppy88 mentioned this pull request Oct 30, 2024
Merged
@sklppy88 sklppy88 changed the title init feat: adding tags to sent notes Oct 30, 2024
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-sender-to-encode-and-encrypt-payload branch 2 times, most recently from 587f3f3 to 909ecf4 Compare October 30, 2024 10:51
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch 2 times, most recently from 947a864 to 4435b30 Compare October 30, 2024 10:54
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-sender-to-encode-and-encrypt-payload branch from 909ecf4 to 72781e1 Compare October 30, 2024 11:46
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch from 4435b30 to e1e9e42 Compare October 30, 2024 11:46
@sklppy88 sklppy88 changed the base branch from ek/feat/new-note-tagging-scheme-implementation/add-sender-to-encode-and-encrypt-payload to ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles October 30, 2024 11:46
@sklppy88 sklppy88 mentioned this pull request Oct 30, 2024
Merged
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles branch from 5a7f73b to 16efbda Compare October 30, 2024 11:47
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch from e1e9e42 to 253826d Compare October 30, 2024 11:47
@sklppy88 sklppy88 marked this pull request as ready for review October 30, 2024 13:08
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles branch from 16efbda to 1fad06a Compare October 30, 2024 14:05
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch 3 times, most recently from 8926ba0 to bc1c219 Compare October 30, 2024 15:01
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles branch from 1fad06a to f6c3749 Compare October 31, 2024 01:24
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch from bc1c219 to 7a9f38c Compare October 31, 2024 01:24
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles branch from f6c3749 to 64a1c8c Compare October 31, 2024 03:26
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch 2 times, most recently from 82c6a3e to 3bd8c51 Compare October 31, 2024 06:02
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles branch from 64a1c8c to 8311c65 Compare October 31, 2024 06:31
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch from 3bd8c51 to ae693bb Compare October 31, 2024 06:32
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles branch 2 times, most recently from 4ca53d3 to 3d7771e Compare October 31, 2024 07:51
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch from ae693bb to d611877 Compare October 31, 2024 07:51
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles branch from 3d7771e to a8bd72f Compare October 31, 2024 09:02
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch from 90b9f43 to a07e5db Compare October 31, 2024 14:37
@sklppy88 sklppy88 changed the base branch from ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles to ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation October 31, 2024 14:37
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch from a07e5db to d5ca596 Compare October 31, 2024 14:41
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation branch from f6e4e0f to 7c33d2a Compare November 1, 2024 09:47
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch from d5ca596 to d1dfc29 Compare November 1, 2024 10:00
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation branch from 7c33d2a to 9ffbb33 Compare November 1, 2024 10:23
@sklppy88 sklppy88 linked an issue Nov 1, 2024 that may be closed by this pull request
Tag logs as a sender #9373
Closed
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch 2 times, most recently from 90d3390 to 58bfcdc Compare November 1, 2024 10:33
Base automatically changed from ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation to master November 1, 2024 10:46
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch 7 times, most recently from f88a873 to 691a04d Compare November 2, 2024 15:32
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch from 691a04d to abcc971 Compare November 2, 2024 16:32
@sklppy88 sklppy88 changed the title feat: adding tags to encoded and encrypted notes feat: adding tags to encrypted logs Nov 2, 2024
@sklppy88 sklppy88 merged commit 64ae6b1 into master Nov 2, 2024
65 checks passed
@sklppy88 sklppy88 deleted the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch November 2, 2024 17:15
@AztecBot AztecBot mentioned this pull request Nov 2, 2024
Merged
TomAFrench added a commit that referenced this pull request Nov 4, 2024
@TomAFrench
Merge branch 'master' into sync-noir
856f3c3 
* master: (81 commits)
  feat: Encode static error strings in the ABI (#9552)
  chore: redo typo PR by donatik27 (#9693)
  chore: update install instructions for foundry to display version of rust to install (#9653)
  chore: disable bench upload until #9692
  fix: earthly-ci in bench-e2e (#9689)
  chore: redo typo PR by cypherpepe (#9687)
  chore: redo typo PR by youyyytrok (#9686)
  chore: redo typo PR by mdqst (#9685)
  chore: redo typo PR by mdqst (#9684)
  feat: adding tags to encrypted logs (#9566)
  fix: enable gerousia e2e test (#9677)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  chore: redo typo PR by dsarfed (#9667)
  fix: bench e2e jobs (#9662)
  fix: Fix random for Mac users  (#9670)
  feat: Graph methods for circuit analysis (part 1) (#7948)
  feat: Faster random sampling (#9655)
  ...
TomAFrench added a commit that referenced this pull request Nov 4, 2024
@TomAFrench
Merge branch 'master' into sync-noir
5254d40 
* master: (83 commits)
  fix: update solhint (#9399)
  chore: redo typo PR by leopardracer (#9705)
  feat: Encode static error strings in the ABI (#9552)
  chore: redo typo PR by donatik27 (#9693)
  chore: update install instructions for foundry to display version of rust to install (#9653)
  chore: disable bench upload until #9692
  fix: earthly-ci in bench-e2e (#9689)
  chore: redo typo PR by cypherpepe (#9687)
  chore: redo typo PR by youyyytrok (#9686)
  chore: redo typo PR by mdqst (#9685)
  chore: redo typo PR by mdqst (#9684)
  feat: adding tags to encrypted logs (#9566)
  fix: enable gerousia e2e test (#9677)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  chore: redo typo PR by dsarfed (#9667)
  fix: bench e2e jobs (#9662)
  fix: Fix random for Mac users  (#9670)
  ...
@ludamad ludamad mentioned this pull request Nov 4, 2024
Closed
This was referenced Nov 5, 2024
Merged
Closed
nventuro added a commit that referenced this pull request Nov 6, 2024
@nventuro
chore: add unsafe comments (#9761)
7802fc8 
I added some small safety comments to the oracles in
#9566, and moved the
tag computation over to an unconstrained helper: since the tag secret
itself is unconstrained, there is no point in constraining the
computation of the tag itself, and we might as well inject the final
value directly.
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this pull request Nov 7, 2024
@nventuro @AztecBot
chore: add unsafe comments (#9761)
02f1bb9 
I added some small safety comments to the oracles in
AztecProtocol/aztec-packages#9566, and moved the
tag computation over to an unconstrained helper: since the tag secret
itself is unconstrained, there is no point in constraining the
computation of the tag itself, and we might as well inject the final
value directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thunkar Thunkar Thunkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag logs as a sender
2 participants
@sklppy88 @Thunkar