Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use address book in recipient tag calculation #9618

Conversation

sklppy88
Copy link
Contributor

@sklppy88 sklppy88 commented Oct 31, 2024

A simple refactor to use our address book instead of the complete address db (which was used before because we were using registerRecipient as a standin for the address book) when we calculate tags for getting our incoming notes from the node.

@sklppy88 sklppy88 changed the title init feat: use address book in recipient tag calculation Oct 31, 2024
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation branch from 75da85e to b8481ab Compare October 31, 2024 09:47
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch from bb6a3a1 to 4fb64a7 Compare October 31, 2024 13:12
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation branch from b8481ab to e45714a Compare October 31, 2024 13:12
@sklppy88 sklppy88 marked this pull request as ready for review October 31, 2024 13:14
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes branch from 4fb64a7 to 90b9f43 Compare October 31, 2024 13:42
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation branch from e45714a to 8ada3c6 Compare October 31, 2024 13:43
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation branch from 8ada3c6 to d350085 Compare October 31, 2024 14:33
@sklppy88 sklppy88 changed the base branch from ek/feat/new-note-tagging-scheme-implementation/add-tags-to-sent-notes to ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles October 31, 2024 14:33
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles branch from f5f9542 to e636349 Compare October 31, 2024 14:36
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation branch from d350085 to f6e4e0f Compare October 31, 2024 14:36
@sklppy88 sklppy88 added the e2e-all CI: Enables this CI job. label Oct 31, 2024
Base automatically changed from ek/feat/new-note-tagging-scheme-implementation/add-increment-secret-oracles to master October 31, 2024 15:29
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation branch from f6e4e0f to 7c33d2a Compare November 1, 2024 09:47
@sklppy88 sklppy88 force-pushed the ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation branch from 7c33d2a to 9ffbb33 Compare November 1, 2024 10:23
@sklppy88 sklppy88 enabled auto-merge (squash) November 1, 2024 10:35
@sklppy88 sklppy88 merged commit 5e33ed8 into master Nov 1, 2024
67 checks passed
@sklppy88 sklppy88 deleted the ek/feat/new-note-tagging-scheme-implementation/use-address-book-in-recipient-tag-calculation branch November 1, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-all CI: Enables this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants