-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gate count profiling for transactions #9632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, barring a minor typo LGTM!
It would be great to also tackle a bigger refactor of this code basically renaming some methods and avoiding the overuse of the word "simulate". Just saying this since you've become familiar with this part, but definitely a different task!
Yea, can also move simulation things like fee estimation from |
Part of #9299
computeGateCountForCircuit
tobb/execute.s
and use it inkernal_prover
to calculate gate-count per function (under a flag).dryRun
tokernal_prover
to skip ClientIVC proof generation (useful for getting gate count without proof generation)--profile
flag to cli-walletsimulate
command to prints the gate count per circuit, Example:ContractFunctionInteraction.simulate
as it is difficult to change its return type as its widely used.send
) sosimulate
does actual simulation of a transaction and display the full data.