Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add end_gas_used to avm public inputs #9910

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chore: add end_gas_used to avm public inputs #9910

merged 1 commit into from
Nov 13, 2024

Conversation

LeilaWang
Copy link
Collaborator

Please read contributing guidelines and remove this line.

@github-actions GitHub Actions
Copy link
Contributor

Changes to circuit sizes

Generated at commit: 370c8409e0bad9edd48d6ca66806ab07ea0dc524, compared to commit: 6507a74644276f5fe6966b5506d694a9961e4d8b

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_public +2 ❌ +0.00% +4 ❌ +0.00%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_public 470,054 (+2) +0.00% 3,770,560 (+4) +0.00%

dbanks12
dbanks12 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but why does FEE_JUICE_INITIAL_MINT change?

@LeilaWang LeilaWang merged commit 3889def into master Nov 13, 2024
71 checks passed
@LeilaWang LeilaWang deleted the lw/end_gas_used branch November 13, 2024 11:20
@LeilaWang
Copy link
Collaborator Author

Looks good, but why does FEE_JUICE_INITIAL_MINT change?

It was changed in a previous PR and someone forgot to run remake constants!

@AztecBot AztecBot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanks12 dbanks12 dbanks12 approved these changes

@jeanmon jeanmon Awaiting requested review from jeanmon jeanmon is a code owner

@IlyasRidhuan IlyasRidhuan Awaiting requested review from IlyasRidhuan IlyasRidhuan is a code owner

@fcarreiro fcarreiro Awaiting requested review from fcarreiro fcarreiro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeilaWang @dbanks12