Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert changes to ci.yml #9863

Merged
merged 1 commit into from
Nov 9, 2024
Merged

fix: Revert changes to ci.yml #9863

merged 1 commit into from
Nov 9, 2024

Conversation

codygunton
Copy link
Contributor

Reverts changes to the file made in 90696cd.

@codygunton codygunton self-assigned this Nov 9, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Changes to circuit sizes

Generated at commit: 4c7ac5c392aa18ce2c2b477c240dd0b95aec978f, compared to commit: 23c122d36091b3b756084584ecba59b800196d58

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_root +6,944 ❌ +137.75% +29,107 ❌ +1.52%
rollup_block_merge +6,944 ❌ +137.31% +29,107 ❌ +1.52%
rollup_block_root_empty +32 ❌ +51.61% +32 ❌ +1.12%
rollup_block_root +32 ❌ +0.72% +32 ❌ +0.00%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_root 11,985 (+6,944) +137.75% 1,940,902 (+29,107) +1.52%
rollup_block_merge 12,001 (+6,944) +137.31% 1,940,916 (+29,107) +1.52%
rollup_block_root_empty 94 (+32) +51.61% 2,891 (+32) +1.12%
rollup_block_root 4,485 (+32) +0.72% 2,863,248 (+32) +0.00%

@codygunton codygunton requested a review from ludamad November 9, 2024 03:47
@ludamad ludamad enabled auto-merge (squash) November 9, 2024 06:40
@ludamad ludamad merged commit 5299f5f into master Nov 9, 2024
65 checks passed
@ludamad ludamad deleted the cg/revert-ci-changes branch November 9, 2024 06:41
TomAFrench added a commit that referenced this pull request Nov 11, 2024
* master: (182 commits)
  feat(avm): mem specific range check (#9828)
  refactor: remove public kernel inner (#9865)
  chore: Revert "chore: Validate RPC inputs" (#9875)
  Revert "fix: deploy l2 contracts fails on 48 validator" (#9871)
  fix: deploy l2 contracts fails on 48 validator (#9860)
  chore: Validate RPC inputs (#9672)
  fix: fixing devcontainers to use the sandbox docker-compose file (#9782)
  fix: Revert changes to ci.yml (#9863)
  chore: Move epoch and slot durations to config (#9861)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  fix: tree heights that last past 3 days (#9760)
  fix(build): l1-contracts .rebuild_patterns did not cover test files (#9862)
  fix: bench prover test (#9856)
  fix: Fix mac build by calling `count` on durations (#9855)
  feat: zk shplemini (#9830)
  feat: domain separate block proposals and attestations (#9842)
  chore: bump runner cache disk size (#9849)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants