Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TokenLogger #638

Closed
cecheta opened this issue Apr 9, 2024 · 1 comment · Fixed by #862
Closed

Remove TokenLogger #638

cecheta opened this issue Apr 9, 2024 · 1 comment · Fixed by #862
Assignees
@liammoat
Labels
enhancement New feature or request

Comments

@cecheta
Copy link
Collaborator

cecheta commented Apr 9, 2024

Motivation

The TokenLogger class is not necessary, now that App Insights has been integrated into the application properly. As a result, the class can be removed, and replaced with using a normal logger. The env var APPINSIGHTS_CONNECTION_STRING can also be removed completely from the application.

Requirements

A list of requirements to consider this feature delivered

Tasks

To be filled in by the engineer picking up the issue
@cecheta cecheta added the enhancement New feature or request label Apr 9, 2024
@cecheta cecheta mentioned this issue Apr 9, 2024
Merged
@liammoat
Copy link
Collaborator

liammoat commented May 8, 2024

Happy to pick this up 👍 @ross-p-smith

@liammoat liammoat linked a pull request May 9, 2024 that will close this issue
refactor: remove tokenlogger #862
Merged
@liammoat liammoat closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liammoat liammoat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove tokenlogger Azure-Samples/chat-with-your-data-solution-accelerator
2 participants
@liammoat @cecheta