Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to add subnets to spoke vnet #767

Closed
2 tasks done
kmridha92 opened this issue Apr 17, 2024 · 1 comment
Closed
2 tasks done

Option to add subnets to spoke vnet #767

kmridha92 opened this issue Apr 17, 2024 · 1 comment
Labels
Area: Networking 🌐 Issues / PR's related to Networking Status: Wont Fix 👎 This will not be worked on

Comments

@kmridha92
Copy link

Describe the feature end to end, including deployment scenario details under which the feature would occur.

This module "infra-as-code/bicep/orchestration/hubPeeredSpoke/hubPeeredSpoke.bicep" calls "infra-as-code/bicep/modules/spokeNetworking/spokeNetworking.bicep" for setting up spoke vnet. There is no option to add subnet like in "infra-as-code/bicep/modules/hubNetworking/hubNetworking.bicep"

Why is this feature important. Describe why this would be important for your organization and others. Would this impact similar orgs in the same way?

As subnets can not be added while creating vnet, every time I re-run this via pipeline it removes the subnets that were created later on the vnet. It would be easier if there is an option to add subnet like there is in hubNetworking module.

Please provide the correlation id associated with your error or bug.

xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx

Can you describe any alternatives that you have taken since this feature does not exist?

I have a seperate custom module that creates the subnets but the re-run of spokeNetworking module with pipeline removes them.

Feature Implementation

No response

Check previous GitHub issues

  • I have searched the issues for this item and found no duplicate

Code of Conduct

  • I agree to follow this project's Code of Conduct
@oZakari
Copy link
Contributor

oZakari commented Apr 17, 2024

Hi @kmridha92, this looks to be a duplicate of issue #301. We also have the following disclaimer within the spokeNetwork module as well, which provides insight into why we won't be adding subnets to the module.

I'd highly recommend looking at Azure Verified modules if you don't want to have to worry about creating your own module, or if you would like to manage your own module, please take a look at this this Tech Community blog as well as this GitHub Issue to better understand the work that the Azure networking team is doing to support updates to virtual networks without the subnet property.

@oZakari oZakari closed this as completed Apr 17, 2024
@oZakari oZakari added Area: Networking 🌐 Issues / PR's related to Networking Status: Wont Fix 👎 This will not be worked on duplicate labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Networking 🌐 Issues / PR's related to Networking Status: Wont Fix 👎 This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants