Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy assignment definitions deleted in platform/alz/2024.10.0 #77

Closed
JWilkinsonMB opened this issue Oct 19, 2024 · 2 comments
Closed
Assignees

Comments

@JWilkinsonMB
Copy link

It looks like there were a number of policy assignment definitions that were deleted as part of #76, for example platform/alz/policy_assignments/deny_resource_locations.alz_policy_assignment.json

I presume this is correct as I don't see them upstream, but just wanted to confirm that this was the intent, and that if we want to carry on using these assignments that we need to create / copy them into our own library?

Also curious how they got there to begin with as they don't ever seem to have been in the upstream definitions. Looks like it might have come across from CAF? If so is there an argument they should be included to help people migrating?

@matt-FFFFFF
Copy link
Member

Hi!

As this was a major release, we completely synced with the upstream repo, including removing any assignments that were not there.

There was a lot of debt there as in the old module we didn't delete anything. Hope this helps!

You can always copy the assignment into a local library if you want to.

@matt-FFFFFF matt-FFFFFF self-assigned this Oct 23, 2024
@matt-FFFFFF
Copy link
Member

matt-FFFFFF commented Oct 29, 2024

Am going to close this now - feel free to reopen if you need more explanation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants