From 3c234d53e454d83dc3522dfefe11f2be4637790a Mon Sep 17 00:00:00 2001 From: rahul0216 Date: Tue, 19 Nov 2024 13:59:55 +0530 Subject: [PATCH 1/6] Create non-ascii-validations.yaml Adding workflow to validate Non-Ascii chars in content --- .github/workflows/non-ascii-validations.yaml | 24 ++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 .github/workflows/non-ascii-validations.yaml diff --git a/.github/workflows/non-ascii-validations.yaml b/.github/workflows/non-ascii-validations.yaml new file mode 100644 index 00000000000..3e9d6990da1 --- /dev/null +++ b/.github/workflows/non-ascii-validations.yaml @@ -0,0 +1,24 @@ +name: Non-Ascii Validations +run-name: Non-Ascii validation running on ${{ github.ref }} +on: + pull_request: + branches: + - master + + # Allows to run workflow manually from the Actions tab + workflow_dispatch: +jobs: + NonAsciiValidations: + runs-on: ubuntu-latest + env: + buildConfiguration: Release + dotnetSdkVersion: 3.1.401 + steps: + - uses: actions/checkout@v2 + - name: Use .NET Core SDK ${{ env.dotnetSdkVersion }} + uses: actions/setup-dotnet@v1 + with: + dotnet-version: ${{ env.dotnetSdkVersion }} + - name: Run kql validation tests + run: dotnet test **/NonAsciiValidations.Tests.csproj --configuration ${{ env.buildConfiguration }} + \ No newline at end of file From 8889f29d4d65a67153e32b885db015a92d5810f5 Mon Sep 17 00:00:00 2001 From: rahul0216 Date: Tue, 19 Nov 2024 15:01:28 +0530 Subject: [PATCH 2/6] Update non-ascii-validations.yaml --- .github/workflows/non-ascii-validations.yaml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/non-ascii-validations.yaml b/.github/workflows/non-ascii-validations.yaml index 3e9d6990da1..fa2939d593e 100644 --- a/.github/workflows/non-ascii-validations.yaml +++ b/.github/workflows/non-ascii-validations.yaml @@ -1,5 +1,5 @@ name: Non-Ascii Validations -run-name: Non-Ascii validation running on ${{ github.ref }} +run-name: Non-Ascii validation running on ${{ github.ref_name }} on: pull_request: branches: @@ -14,11 +14,12 @@ jobs: buildConfiguration: Release dotnetSdkVersion: 3.1.401 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Use .NET Core SDK ${{ env.dotnetSdkVersion }} - uses: actions/setup-dotnet@v1 + uses: actions/setup-dotnet@v2 with: dotnet-version: ${{ env.dotnetSdkVersion }} - - name: Run kql validation tests - run: dotnet test **/NonAsciiValidations.Tests.csproj --configuration ${{ env.buildConfiguration }} + - name: Run Non-Ascii validation tests + run: dotnet --version + #run: dotnet test **/NonAsciiValidations.Tests.csproj --configuration ${{ env.buildConfiguration }} \ No newline at end of file From 4e3f387dabce52b085a972f3d1312377e475a79b Mon Sep 17 00:00:00 2001 From: rahul0216 Date: Tue, 19 Nov 2024 15:17:00 +0530 Subject: [PATCH 3/6] Update non-ascii-validations.yaml --- .github/workflows/non-ascii-validations.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/non-ascii-validations.yaml b/.github/workflows/non-ascii-validations.yaml index fa2939d593e..c3d5d576d9b 100644 --- a/.github/workflows/non-ascii-validations.yaml +++ b/.github/workflows/non-ascii-validations.yaml @@ -20,6 +20,5 @@ jobs: with: dotnet-version: ${{ env.dotnetSdkVersion }} - name: Run Non-Ascii validation tests - run: dotnet --version - #run: dotnet test **/NonAsciiValidations.Tests.csproj --configuration ${{ env.buildConfiguration }} + run: dotnet test .script/tests/NonAsciiValidationsTests/NonAsciiValidations.Tests.csproj --configuration ${{ env.buildConfiguration }} \ No newline at end of file From 66726b2b5e2c12d4c38f0628f07797fe8895e739 Mon Sep 17 00:00:00 2001 From: rahul0216 Date: Tue, 19 Nov 2024 15:22:38 +0530 Subject: [PATCH 4/6] Update non-ascii-validations.yaml --- .github/workflows/non-ascii-validations.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/non-ascii-validations.yaml b/.github/workflows/non-ascii-validations.yaml index c3d5d576d9b..91bc18b0134 100644 --- a/.github/workflows/non-ascii-validations.yaml +++ b/.github/workflows/non-ascii-validations.yaml @@ -1,5 +1,5 @@ name: Non-Ascii Validations -run-name: Non-Ascii validation running on ${{ github.ref_name }} +run-name: Non-Ascii validation running on ${{ github.event.pull_request.head.repo }} on: pull_request: branches: @@ -16,7 +16,7 @@ jobs: steps: - uses: actions/checkout@v4 - name: Use .NET Core SDK ${{ env.dotnetSdkVersion }} - uses: actions/setup-dotnet@v2 + uses: actions/setup-dotnet@v3 with: dotnet-version: ${{ env.dotnetSdkVersion }} - name: Run Non-Ascii validation tests From 6b4eb3ee9a8ab16835ba1fc362ff37bdcb7ff188 Mon Sep 17 00:00:00 2001 From: rahul0216 Date: Tue, 19 Nov 2024 15:34:31 +0530 Subject: [PATCH 5/6] Update non-ascii-validations.yaml --- .github/workflows/non-ascii-validations.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/non-ascii-validations.yaml b/.github/workflows/non-ascii-validations.yaml index 91bc18b0134..78a19f38846 100644 --- a/.github/workflows/non-ascii-validations.yaml +++ b/.github/workflows/non-ascii-validations.yaml @@ -1,5 +1,5 @@ name: Non-Ascii Validations -run-name: Non-Ascii validation running on ${{ github.event.pull_request.head.repo }} +run-name: Non-Ascii validation running on ${{ github.ref_name }} on: pull_request: branches: From 73514ee5da6613f489e59f1a13be19378a498af6 Mon Sep 17 00:00:00 2001 From: rahul0216 Date: Tue, 19 Nov 2024 16:11:01 +0530 Subject: [PATCH 6/6] Update non-ascii-validations.yaml --- .github/workflows/non-ascii-validations.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/non-ascii-validations.yaml b/.github/workflows/non-ascii-validations.yaml index 78a19f38846..ca37bec3a71 100644 --- a/.github/workflows/non-ascii-validations.yaml +++ b/.github/workflows/non-ascii-validations.yaml @@ -16,7 +16,7 @@ jobs: steps: - uses: actions/checkout@v4 - name: Use .NET Core SDK ${{ env.dotnetSdkVersion }} - uses: actions/setup-dotnet@v3 + uses: actions/setup-dotnet@v4 with: dotnet-version: ${{ env.dotnetSdkVersion }} - name: Run Non-Ascii validation tests