High level design for route flow counter #908
Conversation
| Example: | ||
|
|
||
| ``` | ||
| 127.0.0.1:6379[4]> hgetall FLEX_COUNTER_TABLE|FLOW_CNT_ROUTE |
There was a problem hiding this comment.
Can we use 'global' key instead of FLOW_CNT_ROUTE to be consistent with other tables.
There was a problem hiding this comment.
What do you mean by 'global' key?
There was a problem hiding this comment.
FLEX_COUNTER_TABLE|global
There was a problem hiding this comment.
We have different table for each counter group, please check https://github.com/Azure/sonic-utilities/blob/a0bff26a00d63289c0cbd8ff17f5acf930588553/counterpoll/main.py#L322
| Polling interval configuration: | ||
|
|
||
| ``` | ||
| counterpoll flowcnt-route interval <time_in_msec> // default - 1000ms |
There was a problem hiding this comment.
Hope we'll generate the Click commands using auto generation tool (#780)
There was a problem hiding this comment.
as long as there is a yang module for it you ca use the auto generation tool. but it is not done via the build system.
it will be invoked manually and added like it was coded :-). if this is what you mean that we are aligned and comment can be resolved.
|
@shi-su and @venkatmahalingam could you please review recent updates following your feedback? |
|
@venkatmahalingam and @shi-su any further comment on this HLD or we can signoff? |
|
@venkatmahalingam and @shi-su please take a moment to review the recent changes and if all good, please approve. |
HLD: sonic-net/SONiC#908 Command reference : #2069 - What I did Add CLIs for route flow counter feature - How I did it Add show command show flowcnt-route config and command group show flowcnt-route stats Add config command group config flowcnt-route pattern Add clear command group sonic-clear flowcnt-route - How to verify it 1. Full unit test cover 2. Manual test 3. sonic-mgmt test cases
Added test cases for route flow counter feature. HLD: sonic-net/SONiC#908 - What is the motivation for this PR? Add route flow counter related test cases - How did you do it? 1. Add new test case file test_route_flow_counter.py to covers basic function of this feature 2. Add check in test_vnet_vxlan.py to cover VNET route 3. Add check in test_bgp_speaker.py to cover BGP route 4. Add check in test_static_route.py to cover static route - How did you verify/test it? Run the test cases
HLD: sonic-net/SONiC#908 Command reference : sonic-net/sonic-utilities#2069 - What I did Add CLIs for route flow counter feature - How I did it Add show command show flowcnt-route config and command group show flowcnt-route stats Add config command group config flowcnt-route pattern Add clear command group sonic-clear flowcnt-route - How to verify it 1. Full unit test cover 2. Manual test 3. sonic-mgmt test cases
High level design for route flow counters support.
Flow counters are usually used for debugging, troubleshooting and performance enhancement processes. Flow counters could cover cases like:
This document focus on route flow counter.