Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to azure.core.rest.HttpResponse for version-tolerant=False code gen #2141

Closed
jalauzon-msft opened this issue Sep 22, 2023 · 0 comments · Fixed by #2605
Closed
Labels
lint/typing mq This issue is part of a "milestone of quality" initiative.

Comments

@jalauzon-msft
Copy link
Member

Currently autorest will generate code which produces responses of type azure.core.pipeline.transport.HttpResponse if version-tolerant=False. This namespace is being deprecated and PyLint rules are being introduced to generate errors if this import is used.

Autorest should consider switching to azure.core.rest.HttpResponse even for non-version-tolerant packages as the new class should be fully backwards compatible and therefore it may not be a breaking change to switch these return types. Some testing should probably be done to ensure this is the case though. Note: I autorest has already switched the requests to azure.core.rest.HttpRequest a while back.

CC: @iscai-msft

@iscai-msft iscai-msft added mq This issue is part of a "milestone of quality" initiative. lint/typing labels Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lint/typing mq This issue is part of a "milestone of quality" initiative.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants