Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deserialization issue following moving to new requests and responses #2647

Closed
iscai-msft opened this issue Jun 19, 2024 · 2 comments · Fixed by #2649
Closed

deserialization issue following moving to new requests and responses #2647

iscai-msft opened this issue Jun 19, 2024 · 2 comments · Fixed by #2649
Assignees
Labels
blocking service bug This issue requires a change to an existing behavior in the product in order to be resolved. p0

Comments

@iscai-msft
Copy link
Contributor

iscai-msft commented Jun 19, 2024

Search is running into issues deseiralizing following our pr moving over to new requests and responses. The issue isn't the new requests and responses, the issue is that we are now only deserializing with pipeline_response.http_response instead of pipeline_response. Roll back part of this change, because we don't want to modify core behavior. This is in search

image

cc @xiangyan99

@iscai-msft iscai-msft added bug This issue requires a change to an existing behavior in the product in order to be resolved. p0 blocking service labels Jun 19, 2024
@iscai-msft iscai-msft self-assigned this Jun 19, 2024
@msyyc
Copy link
Member

msyyc commented Jun 20, 2024

I infer search SDK is generated with cmd autorest D:\dev\azure-rest-api-specs\specification\search\data-plane\Azure.Search\readme.md --python --python-sdks-folder=D:\dev\azure-sdk-for-python\sdk --use=@autorest/python@6.14.0 --use=@autorest/modelerfour@4.27.0 --version=3.10.2 --version-tolerant=False --tag=package-2021-04-searchindex-preview

@msyyc
Copy link
Member

msyyc commented Jun 20, 2024

We have test cover this scenario

and I can't reproduce the deserialization issue. Could you provide more details about the issue? @iscai-msft @xiangyan99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking service bug This issue requires a change to an existing behavior in the product in order to be resolved. p0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants