-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modular] Implement Pagination #1856
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@xirzec Could you help review the byPage design in modular? /cc @deyaaeldeen @joheredi @qiaozha Feel free to comment if I missed something. BackgroundFor list operations result sets may be massive so customers may retrieve them page by page according to continuation token. Currently our
|
I like removing I also like One thing I'm curious about is point 3 in your example, changing from I have also been thinking about the compatibility problem with previously shipped clients. I wonder if we could include some way to opt into a |
Sure let's keep it simple with string.
Yeah, I think we should keep
I am also thinking about this and I think adding a companion function would work for me. Another immature idea is that |
Offline confirmed we could look at having it extend the page type so someone returning Array could return Array & { continuationToken: string } but should be careful for the performance impact. |
Say we have below tsp definition
We would expect to generate modular operation
Option 1: One paging helper per operation
Option 2: Leverage pagination helper in RLC
Option 3: A modular generator
See details as below.
The text was updated successfully, but these errors were encountered: