Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Duplicate Interface Names in The Same Module #1998

Closed
minhanh-phan opened this issue Aug 30, 2023 · 4 comments
Closed

[JS] Duplicate Interface Names in The Same Module #1998

minhanh-phan opened this issue Aug 30, 2023 · 4 comments
Assignees
Labels

Comments

@minhanh-phan
Copy link
Member

minhanh-phan commented Aug 30, 2023

The DPG generation for @azure/schema-registry package using this tsp file generates a conflict within the same module. See the duplication for the CustomPage interface in the models.ts module below.
For more reference, here is the generated file. We expect the generated file would not have this conflict.

/** Paged collection of Version items */
export interface CustomPage {
  /** The Version items on this page */
  value: Version[];
  /** The link to the next page of items */
  nextLink?: string;
}
/** Paged collection of SchemaGroup items */
export interface CustomPage {
  /** The SchemaGroup items on this page */
  value: SchemaGroup[];
  /** The link to the next page of items */
  nextLink?: string;
}

To reproduce:

  • Set the tsp-location.yaml with these info
directory: specification/schemaregistry/SchemaRegistry
commit: 64c0f42845bc61cea5762df36b9915d3ef13fcf9
repo: Azure/azure-rest-api-specs
  • Generate
@MaryGao
Copy link
Member

MaryGao commented Sep 1, 2023

@minhanh-phan Thanks for reporting this! The duplicated issue should be fixed in our recent pr but not released yet.

In schema-registry we have the paging operation and please notice that the paging support in modular is still in progress. Not sure we have any timeline for this RP?

listSchemaGroups is resourceOperations.ResourceList<SchemaGroup>;

@MaryGao MaryGao self-assigned this Sep 14, 2023
@MaryGao
Copy link
Member

MaryGao commented Oct 11, 2023

@minhanh-phan I believe this duplicated name's issue is resolved in our latest version, do you think this is still valid?

@MaryGao MaryGao added the HRLC label Oct 11, 2023
@MaryGao
Copy link
Member

MaryGao commented Oct 11, 2023

Closed as it is solved already and feel free to re-open it if necessary.

@MaryGao MaryGao closed this as completed Oct 11, 2023
@minhanh-phan
Copy link
Member Author

@MaryGao I regenerate with the latest version and the issue has been resolved. Thank you 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants