Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #10: CADL Generated Issue in the Content Safety SDK #2004

Closed
sarangan12 opened this issue Sep 5, 2023 · 3 comments
Closed

Issue #10: CADL Generated Issue in the Content Safety SDK #2004

sarangan12 opened this issue Sep 5, 2023 · 3 comments
Assignees
Labels
HRLC needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue.

Comments

@sarangan12
Copy link
Member

sarangan12 commented Sep 5, 2023

I have tried generating a new JS SDK Package for Azure AI Content Safety. In the generation process, I have found the following issue.

Input
main.tsp - Link
models.tsp - Link
routes.tsp - Link
tspconfig.yaml

emit:
  - "@azure-tools/typespec-ts"
options:
  "@azure-tools/typespec-ts":
    generateMetadata: true
    generateTest: false
    multiClient: false
    azureSdkForJs: true
    isModularLibrary: true
    "emitter-output-dir": "{project-root}/sdk/cognitiveservices/cognitiveservices-contentsafety"
    packageDetails:
      name: "@azure-rest/ai-content-safety"
      description: "ContentSafety Service"

Steps to generate

  1. npx tsp compile .
  2. rushx build

Issue
There are 34 errors reported in the build process. I was able to classify them into 3 groups:

  1. The property uint8ArrayToString has been imported from @azure/core-util. There is no such export.
  2. The following properties have been defined both in models.ts & options.ts and causes conflict:
  • AddBlockItemsOptions
  • AnalyzeTextOptions
  • AnalyzeImageOptions
  • RemoveBlockItemsOptions
  1. The generated method _analyzeImageSend has issue with body definition. A similar issue has been observed in the _listTextBlocklistItemsDeserialize method also.

Please take a look. @xirzec @joheredi FYI....

@qiaozha
Copy link
Member

qiaozha commented Sep 5, 2023

Those should have been fixed in the latest codegen. not sure if we ever have a release after the fixes. #1975

@qiaozha
Copy link
Member

qiaozha commented Sep 11, 2023

@sarangan12 Could you try the latest emitter to see if those issues still exist ?

@qiaozha qiaozha self-assigned this Sep 13, 2023
@qiaozha qiaozha added HRLC needs-author-feedback Workflow: More information is needed from author to address the issue. labels Sep 13, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Sep 20, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hi, we're sending this friendly reminder because we haven't heard back from you in 7 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HRLC needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue.
Projects
None yet
Development

No branches or pull requests

2 participants