Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dpg - Generate nullability consistently between RLC and DPG #2064

Closed
3 tasks done
joheredi opened this issue Oct 17, 2023 · 1 comment
Closed
3 tasks done

Dpg - Generate nullability consistently between RLC and DPG #2064

joheredi opened this issue Oct 17, 2023 · 1 comment
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. non-azure

Comments

@joheredi
Copy link
Member

joheredi commented Oct 17, 2023

Some inconsistencies:

  • Date deserialization needs to handle string | null.
  • The system does not handle nullable dates
  • Classification_betas? emitted wrongly as (number | null)[] in modular models. Workaround: Change to number[] | null.
@joheredi joheredi added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Oct 17, 2023
@qiaozha qiaozha self-assigned this Oct 18, 2023
@joheredi
Copy link
Member Author

Fixed with #2076

@qiaozha qiaozha assigned joheredi and unassigned qiaozha Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. non-azure
Projects
None yet
Development

No branches or pull requests

3 participants