Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit modular models generation in multi clients #2611

Open
qiaozha opened this issue Jun 23, 2024 · 0 comments · May be fixed by #2759
Open

revisit modular models generation in multi clients #2611

qiaozha opened this issue Jun 23, 2024 · 0 comments · May be fixed by #2759
Assignees
Labels
HRLC p0 priority 0

Comments

@qiaozha
Copy link
Member

qiaozha commented Jun 23, 2024

This is the bug from #2554 our customers and I have a pr to fix this #2556 (comment) bug is because we didn't add subfolder in the serialize util filepath part, but as getAllModel api doesn't really have a SDKClient parameter, the models are not filtered by clients, what we end up now for multi clients in Modular are just duplicate the models in each sub client's folder, and as serialize and deserialize utils are bind with models, we will have to duplicate that part too right? I think we have three options for this:

  1. keep the way as is now.
  2. to just have one /models subpath export in multi client scenarios, instead of have /subclient/models for each sub client.
  3. ask tcgc to provide api that can filter the models per SDK client, or we can do the filter by ourself, but what about orphan models in this case?
@qiaozha qiaozha self-assigned this Jun 26, 2024
@qiaozha qiaozha added HRLC p0 priority 0 labels Jun 26, 2024
@qiaozha qiaozha linked a pull request Sep 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HRLC p0 priority 0
Projects
None yet
1 participant