Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a line on contribute doc to ask author publishing Microsoft authorized template to azure samples browser #404

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

hemarina
Copy link
Contributor

@hemarina hemarina commented Jun 18, 2024

The manual test team are constantly tracking and creating PRs to publish msft authorized templates to azure samples browser. We should consider letting the author decides if they want to add their templates on azure samples browser.

Copy link
Contributor

@kristenwomack kristenwomack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a change, and I have an open question on a point I don't understand. I'm supportive of the spirit of this change. We'll want to also look at this in the lens of the azd artifacts in the template standardization effort.

website/docs/contribute.md Outdated Show resolved Hide resolved
website/docs/contribute.md Show resolved Hide resolved
website/docs/contribute.md Outdated Show resolved Hide resolved
Co-authored-by: Grace Kulin <55554236+gkulin@users.noreply.github.com>
Copy link
Contributor

@kristenwomack kristenwomack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hemarina hemarina requested a review from gkulin June 20, 2024 17:09
@hemarina hemarina merged commit e8da0ae into Azure:main Jun 20, 2024
2 checks passed
@hemarina hemarina changed the title Add a line on PR description to ask author publishing Microsoft authorized template to azure samples browser Add a line on contribute doc to ask author publishing Microsoft authorized template to azure samples browser Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants