Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add LlamaIndex template (javaScript) #405

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

manekinekko
Copy link
Member

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

Your template repository

Place your template repository link here:

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

    • Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

    • Link to Author's GitHub or other relevant website - Used for attribution

    • Author's Name - Name to credit on the gallery card

    • Link to template source - Link to the template GitHub repo

    • Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!

      Required tags:

      • Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
      • Tag the IaC provider ("bicep" or "terraform")
      • At least 1 tag for programming language used
      • At least 1 tag for Azure services integrated
      • Add the "new" tag for any newly authored templates
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

If you are submitting a resource to be added to the awesome-azd README:

  • Name of resource
  • Resource author - who created this resource? (so we can credit them!)
  • What section should this resource be included in? -Is the resource an article? A video? Something else?

@manekinekko
Copy link
Member Author

PR with azd support: Azure-Samples/llama-index-javascript@b301699

@hemarina
Copy link
Contributor

@v-xuto Could you test this template?

@v-xuto
Copy link
Member

v-xuto commented Jun 25, 2024

@v-xuto Could you test this template?

Got it. We will start testing this template.

@manekinekko
Copy link
Member Author

Thanks a lot @hemarina and @v-xuto :)

@manekinekko
Copy link
Member Author

Thanks @v-xuto for taking the time to test the sample. I managed to fix 3 out of 4 issues. Issue Azure-Samples/llama-index-javascript#9 is pending for now.

@v-xuto
Copy link
Member

v-xuto commented Jul 8, 2024

@manekinekko We retested the code based on your fix and found one new issue. Please review.

@manekinekko
Copy link
Member Author

@v-xuto can you please check again. I fixed the issue.

@v-xuto
Copy link
Member

v-xuto commented Jul 16, 2024

@v-xuto can you please check again. I fixed the issue.

@manekinekko Currently, we still have Issue9 left. When we re-tested, we encountered a new error. Please review.

@manekinekko
Copy link
Member Author

@v-xuto issue. azd pipeline config is working as expected https://github.com/Azure-Samples/llama-index-javascript/actions/runs/9957204618/job/27509469889

@manekinekko
Copy link
Member Author

Hi @v-xuto all issues have been fixed. Let me know if there is anything else. Thank you.

cc @kristenwomack

@v-xuto
Copy link
Member

v-xuto commented Jul 25, 2024

@hemarina All issues have been fixed. There are currently no issues with this template. Please review.

@kristenwomack kristenwomack self-requested a review July 25, 2024 18:27
Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hemarina hemarina merged commit 96853c4 into Azure:main Jul 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants