Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit pinecone-rag-demo-azd #410

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Conversation

cwaddingham
Copy link
Contributor

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

Your template repository

Place your template repository link here: https://github.com/pinecone-io/pinecone-rag-demo-azd

  • [x ] Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • [x ] Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

    • [x ] Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

    • [x ] Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

    • [x ] Link to Author's GitHub or other relevant website - Used for attribution

    • [ x] Author's Name - Name to credit on the gallery card

    • [x ] Link to template source - Link to the template GitHub repo

    • [ x] Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!

      Required tags:

      • [x ] Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
      • [x ] Tag the IaC provider ("bicep" or "terraform")
      • [x ] At least 1 tag for programming language used
      • [x ] At least 1 tag for Azure services integrated
      • [ x] Add the "new" tag for any newly authored templates
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

If you are submitting a resource to be added to the awesome-azd README:

  • Name of resource
  • Resource author - who created this resource? (so we can credit them!)
  • What section should this resource be included in? -Is the resource an article? A video? Something else?

@cwaddingham
Copy link
Contributor Author

cwaddingham commented Jun 27, 2024 via email

@hemarina
Copy link
Contributor

@v-xuto Could you test this template please?

@v-xuto
Copy link
Member

v-xuto commented Jun 28, 2024

@v-xuto Could you test this template please?

Got it. Testing.

@cwaddingham
Copy link
Contributor Author

Hi @v-xuto, I just pushed some fixes to the template's main branch related to the shell script that creates the local environment file. You may want to pull those changes into your local testing.

@v-xuto
Copy link
Member

v-xuto commented Jul 2, 2024

@hemarina, @cwaddingham We have finished this template test, and we filed two issues. Please review.

@v-xuto
Copy link
Member

v-xuto commented Jul 15, 2024

@hemarina All issues have been fixed. There are currently no issues with this template. Please review.

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwaddingham Thank you very much for contributing! This template will be synced on our weekly release day 7/17. If you prefer to have it live early, let us know and we will release by requests.

@hemarina hemarina merged commit fe8a6b7 into Azure:main Jul 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants