Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fastapi entries #417

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add fastapi entries #417

wants to merge 2 commits into from

Conversation

bobtabor-msft
Copy link

@bobtabor-msft bobtabor-msft commented Jul 17, 2024

Hi Awesome AZD team. We are working with the App Service team, the App Service writers, and Cloud Advocacy to add FastAPI support to this article:

https://learn.microsoft.com/en-us/azure/app-service/tutorial-python-postgresql-app

... and one of those requirements is to add azd support (as a template). We basically copied the Flask version of the \infra and made almost no changes to that part. Please let me know if there's anything we can do to expedite this. Thank you!

Here's what you asked for:

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

Your template repository

Place your template repository link here:

REVIEWERS PLEASE READ THIS

Looks like the instructions may have changed here so I did as much as I could. For example, I added an entry to /website/src/static/templates.json, and since this is the FastAPI version of an existing AZD template, I just used the same tags (changing 'Flask' to 'FastAPI').

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

    • Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

    • Link to Author's GitHub or other relevant website - Used for attribution

    • Author's Name - Name to credit on the gallery card

    • Link to template source - Link to the template GitHub repo

    • Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!

      Required tags:

      • Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
      • Tag the IaC provider ("bicep" or "terraform")
      • At least 1 tag for programming language used
      • At least 1 tag for Azure services integrated
      • Add the "new" tag for any newly authored templates
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

^^ Did not do this because we build the application starting with the Flask version of the repo (which already had the \infra\ bicep files) and didn't make any changes.

If you are submitting a resource to be added to the awesome-azd README:

  • Name of resource
  • Resource author - who created this resource? (so we can credit them!)
  • What section should this resource be included in? -Is the resource an article? A video? Something else?

@bobtabor-msft bobtabor-msft marked this pull request as ready for review July 17, 2024 19:12
@hemarina
Copy link
Contributor

@v-xuto Could you test this template please?

@v-xuto
Copy link
Member

v-xuto commented Jul 22, 2024

@v-xuto Could you test this template please?

Got it. We will test this template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants