Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Adds DOCUMENTID extension method for LINQ #4489

Merged

Conversation

leminh98
Copy link
Contributor

@leminh98 leminh98 commented May 14, 2024

Pull Request Template

Description

This PR adds the extension method to support the documentId system function in LINQ

Usage: linqQuery.Select(x => x.DocumentId())

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #2607

@adityasa
Copy link
Contributor

Please include test coverage.

Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@leminh98 leminh98 added the auto-merge Enables automation to merge PRs label May 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) May 21, 2024 20:42
adityasa
adityasa previously approved these changes May 22, 2024
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Maya-Painter
Maya-Painter previously approved these changes May 31, 2024
adityasa
adityasa previously approved these changes May 31, 2024
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@leminh98 leminh98 dismissed stale reviews from Maya-Painter, adityasa, and kirankumarkolli via 6e9fd7d June 3, 2024 20:19
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@leminh98 leminh98 disabled auto-merge June 4, 2024 19:47
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) June 4, 2024 19:47
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 18a677a into master Jun 4, 2024
21 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/leminh/DocumentIdExtensionMethod branch June 4, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Call DOCUMENTID(root) from LINQ provider
4 participants